Replace Foldable1 primitives #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tency checks. It is now a free theorem that the call structure of a Foldable1's left fold looks like f(f(f(z(a), a), a), a) for some arbitrary depth, i.e. is called left-associative. Likewise, the left fold must be called as f(a, f(a, f(a, z(a)))) for some arbitrary depth. We formerly tested this property, but with foldMapLeft1 and foldMapRight1 as primitives with the above free theorems, this is no longer necessary. So we just reformulate the (still valuable) consistency checks from Foldable.
|
Awesome 👍 |
|
This is a source-breaking change. I suspect it's easy to deal with though, so I'm just going to point to 17c9f21 in the release notes. |
|
@larsrh Yes on all counts. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primitives, introduced in f29c54d, should be easier to use in more cases. The essential difference is the new initializer.
It also requires testing less stuff. dcc224e explains the advantages. For reference, the problem was obliquely referred to originally in b8ca77e.
How does this sound to you, @puffnfresh?